Skip to content

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Jan 12, 2026

Description

Needed some changes around stackable-webhook

--- PASS: kuttl (158.21s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/tls-truststore_openshift-false_truststore-target-kind-ConfigMap (6.66s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-3072_custom-secret-names-False (19.59s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-2048_custom-secret-names-False (18.49s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-2048_custom-secret-names-True (17.49s)
        --- PASS: kuttl/harness/tls-truststore_openshift-false_truststore-target-kind-Secret (6.44s)
        --- PASS: kuttl/harness/listener_openshift-false (32.71s)
        --- PASS: kuttl/harness/cert-manager-tls_openshift-false (66.55s)
        --- PASS: kuttl/harness/tls_openshift-false_rsa-key-length-3072_custom-secret-names-True (14.64s)
        --- PASS: kuttl/harness/kerberos_krb5-1.21.1_openshift-false (81.96s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sbernauer sbernauer self-assigned this Jan 12, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Jan 12, 2026
@maltesander maltesander self-requested a review January 12, 2026 15:46
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 12, 2026
maltesander
maltesander previously approved these changes Jan 12, 2026
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

maltesander
maltesander previously approved these changes Jan 13, 2026
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer
Copy link
Member Author

Sorry, needed another CI fix

@sbernauer sbernauer requested a review from maltesander January 13, 2026 08:20
@sbernauer sbernauer enabled auto-merge January 13, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

3 participants